Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163083002: Files.app: Show error messages for the case the source file is not exists. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: Show error messages for the case the source file is not exists. Previously the error message is shown in a dialog box, but it was broken and currently there are no errors. The CLs shows the error message in the progress center. BUG=341400 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251782

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/common/js/util.js View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_transfer_controller.js View 1 2 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 10 months ago (2014-02-13 08:10:02 UTC) #1
hirono
On 2014/02/13 08:10:02, hirono wrote: > PTAL the CL? Thanks! @yoshiki - ping?
6 years, 10 months ago (2014-02-14 07:34:48 UTC) #2
yoshiki
https://codereview.chromium.org/163083002/diff/50001/chrome/browser/resources/file_manager/common/js/util.js File chrome/browser/resources/file_manager/common/js/util.js (right): https://codereview.chromium.org/163083002/diff/50001/chrome/browser/resources/file_manager/common/js/util.js#newcode1152 chrome/browser/resources/file_manager/common/js/util.js:1152: * Entries. Please mention that the both errorCallback and ...
6 years, 10 months ago (2014-02-14 10:24:11 UTC) #3
hirono
Thanks! https://codereview.chromium.org/163083002/diff/50001/chrome/browser/resources/file_manager/common/js/util.js File chrome/browser/resources/file_manager/common/js/util.js (right): https://codereview.chromium.org/163083002/diff/50001/chrome/browser/resources/file_manager/common/js/util.js#newcode1152 chrome/browser/resources/file_manager/common/js/util.js:1152: * Entries. On 2014/02/14 10:24:11, yoshiki wrote: > ...
6 years, 10 months ago (2014-02-14 10:42:37 UTC) #4
yoshiki
Sorry for late response. lgtm
6 years, 10 months ago (2014-02-17 23:46:12 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-18 14:31:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/163083002/130001
6 years, 10 months ago (2014-02-18 14:31:52 UTC) #7
hirono
On 2014/02/18 14:31:52, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 10 months ago (2014-02-18 14:32:40 UTC) #8
hirono
On 2014/02/18 14:32:40, hirono wrote: > On 2014/02/18 14:31:52, I haz the power (commit-bot) wrote: ...
6 years, 10 months ago (2014-02-18 14:32:50 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:47:46 UTC) #10
Message was sent while issue was closed. 
Change committed as 251782

Powered by Google App Engine
This is Rietveld 408576698