Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1630823004: [SVG] Remove PathParsingMode (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
pdr., fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SVG] Remove PathParsingMode After http://crrev.com/1623073003, we always call SVGPathParser::parsePathDataFromSource in unaltered mode. R=fs@opera.com,pdr@chromium.org Committed: https://crrev.com/a7465ce56e5a3813fa6aaedc0b680aa7b76a6bcc Cr-Commit-Position: refs/heads/master@{#371545}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathParser.h View 1 2 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathParser.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
f(malita)
I was hoping to get rid of SVGPathNormalizer too, but it's still used in SVGPathQuery.
4 years, 11 months ago (2016-01-26 15:21:00 UTC) #1
fs
lgtm
4 years, 11 months ago (2016-01-26 15:31:28 UTC) #2
pdr.
lgtm
4 years, 11 months ago (2016-01-26 18:28:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630823004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630823004/20001
4 years, 11 months ago (2016-01-26 18:28:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 18:37:29 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 18:38:50 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a7465ce56e5a3813fa6aaedc0b680aa7b76a6bcc
Cr-Commit-Position: refs/heads/master@{#371545}

Powered by Google App Engine
This is Rietveld 408576698