Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1630823002: Move mojo/runner to mojo/shell/standalone (Closed)

Created:
4 years, 11 months ago by Ben Goodger (Google)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move mojo/runner to mojo/shell/standalone BUG= Committed: https://crrev.com/f7946d59b741c0ceec77c5118c195950affba71f Cr-Commit-Position: refs/heads/master@{#371411}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -4245 lines) Patch
M components/html_viewer/html_document_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/test_runner/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/test_runner/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/test_runner/launcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/test_runner/register_local_aliases.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M mandoline/app/android/mandoline_activity.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/app/android/mandoline_context_init.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/app/desktop/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/app/desktop/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mandoline/app/register_local_aliases.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/example/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/public/mojo_application.gni View 1 2 chunks +5 lines, -5 lines 0 comments Download
D mojo/runner/BUILD.gn View 1 chunk +0 lines, -311 lines 0 comments Download
D mojo/runner/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/runner/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/runner/android/android_handler.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/runner/android/android_handler.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D mojo/runner/android/android_handler_loader.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/runner/android/android_handler_loader.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/runner/android/apk/AndroidManifest.xml View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/runner/android/apk/res/values/strings.xml View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 chunk +0 lines, -258 lines 0 comments Download
D mojo/runner/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 1 chunk +0 lines, -257 lines 0 comments Download
D mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/runner/android/background_application_loader.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/runner/android/background_application_loader.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/runner/android/background_application_loader_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/runner/android/bootstrap.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/runner/android/context_init.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/runner/android/context_init.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/runner/android/library_loader.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/runner/android/main.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/runner/android/main.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D mojo/runner/android/run_android_application_function.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/runner/android/ui_application_loader_android.h View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/runner/android/ui_application_loader_android.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/runner/context.h View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/runner/context.cc View 1 chunk +0 lines, -356 lines 0 comments Download
D mojo/runner/desktop/launcher_process.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/runner/desktop/launcher_process.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/runner/desktop/main.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/runner/desktop/main_helper.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/runner/desktop/main_helper.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/runner/register_local_aliases.h View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/runner/register_local_aliases.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/runner/scoped_user_data_dir.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/runner/scoped_user_data_dir.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/runner/shell_apptest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D mojo/runner/shell_test_base.h View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/runner/shell_test_base_unittest.cc View 1 chunk +0 lines, -297 lines 0 comments Download
D mojo/runner/shell_test_main.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/runner/switches.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/runner/switches.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/runner/task_runners.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/runner/task_runners.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/runner/test/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/runner/test/pingable_app.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/runner/tracer.h View 1 chunk +0 lines, -102 lines 0 comments Download
D mojo/runner/tracer.cc View 1 chunk +0 lines, -164 lines 0 comments Download
A + mojo/shell/standalone/BUILD.gn View 1 2 3 7 chunks +14 lines, -18 lines 0 comments Download
A + mojo/shell/standalone/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/android/android_handler.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/android/android_handler.cc View 1 8 chunks +9 lines, -12 lines 0 comments Download
A + mojo/shell/standalone/android/android_handler_loader.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + mojo/shell/standalone/android/android_handler_loader.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
A + mojo/shell/standalone/android/apk/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/android/apk/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
A + mojo/shell/standalone/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/standalone/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/shell/standalone/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/shell/standalone/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
A + mojo/shell/standalone/android/background_application_loader.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + mojo/shell/standalone/android/background_application_loader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/standalone/android/background_application_loader_unittest.cc View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
A + mojo/shell/standalone/android/bootstrap.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/shell/standalone/android/context_init.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/android/context_init.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/android/library_loader.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/shell/standalone/android/main.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/android/main.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
A + mojo/shell/standalone/android/run_android_application_function.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/android/ui_application_loader_android.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/shell/standalone/android/ui_application_loader_android.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/standalone/context.h View 1 4 chunks +13 lines, -16 lines 0 comments Download
A + mojo/shell/standalone/context.cc View 1 10 chunks +29 lines, -33 lines 0 comments Download
A + mojo/shell/standalone/desktop/launcher_process.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/desktop/launcher_process.cc View 1 4 chunks +9 lines, -10 lines 0 comments Download
A + mojo/shell/standalone/desktop/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/shell/standalone/desktop/main_helper.h View 1 1 chunk +10 lines, -9 lines 0 comments Download
A + mojo/shell/standalone/desktop/main_helper.cc View 1 2 3 4 3 chunks +11 lines, -10 lines 0 comments Download
A + mojo/shell/standalone/register_local_aliases.h View 1 chunk +5 lines, -8 lines 0 comments Download
A + mojo/shell/standalone/register_local_aliases.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/shell/standalone/scoped_user_data_dir.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/scoped_user_data_dir.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
A + mojo/shell/standalone/shell_apptest.cc View 1 2 3 4 4 chunks +6 lines, -7 lines 0 comments Download
A + mojo/shell/standalone/shell_test_base.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/shell/standalone/shell_test_base_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/standalone/shell_test_main.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/standalone/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/standalone/task_runners.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/task_runners.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/test/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/standalone/test/pingable_app.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
A + mojo/shell/standalone/tracer.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/standalone/tracer.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Ben Goodger (Google)
4 years, 11 months ago (2016-01-25 18:49:33 UTC) #2
sky
Rubber stamp LGTM
4 years, 11 months ago (2016-01-25 20:13:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630823002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630823002/60001
4 years, 11 months ago (2016-01-25 22:25:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/138785)
4 years, 11 months ago (2016-01-25 22:44:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630823002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630823002/80001
4 years, 11 months ago (2016-01-26 00:17:37 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-26 01:44:29 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:45:36 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f7946d59b741c0ceec77c5118c195950affba71f
Cr-Commit-Position: refs/heads/master@{#371411}

Powered by Google App Engine
This is Rietveld 408576698