third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp - Issue 1630793002: Stop hit testing culled inlines when a match is found

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

Issue 1630793002: Stop hit testing culled inlines when a match is found (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simpler approach, but duplicated code Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

index a7e1d655f7af72369179b0db83feed79eb4fa4d2..d0391351da0e4d810ee45fc6b3cce5e8d0f064e0 100644

--- a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

@@ -266,7 +266,7 @@ bool SVGInlineTextBox::nodeAtPoint(HitTestResult& result, const HitTestLocation&

FloatQuad fragmentQuad = fragment.boundingQuad(baseline);

if (fragmentQuad.containsPoint(floatLocation)) {

lineLayoutItem.updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));

- if (!result.addNodeToListBasedTestResult(lineLayoutItem.node(), locationInContainer, rect))

+ if (result.addNodeToListBasedTestResult(lineLayoutItem.node(), locationInContainer, rect) == StopHitTesting)

return true;

}

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp ('k') | no next file » | no next file with comments »