third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp - Issue 1630793002: Stop hit testing culled inlines when a match is found

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 1630793002: Stop hit testing culled inlines when a match is found (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simpler approach, but duplicated code Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

index 4a9ba97a335d438845d91358f53c913741582e11..d8910482f3ac789b5e0eb441b780f7303d371b36 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

@@ -174,7 +174,7 @@ bool LayoutSVGContainer::nodeAtFloatPoint(HitTestResult& result, const FloatPoin

if (child->nodeAtFloatPoint(result, localPoint, hitTestAction)) {

const LayoutPoint& localLayoutPoint = roundedLayoutPoint(localPoint);

updateHitTestResult(result, localLayoutPoint);

- if (!result.addNodeToListBasedTestResult(child->node(), localLayoutPoint))

+ if (result.addNodeToListBasedTestResult(child->node(), localLayoutPoint) == StopHitTesting)

return true;

}

@@ -185,7 +185,7 @@ bool LayoutSVGContainer::nodeAtFloatPoint(HitTestResult& result, const FloatPoin

if (objectBoundingBox().contains(localPoint)) {

const LayoutPoint& localLayoutPoint = roundedLayoutPoint(localPoint);

updateHitTestResult(result, localLayoutPoint);

- if (!result.addNodeToListBasedTestResult(element(), localLayoutPoint))

+ if (result.addNodeToListBasedTestResult(element(), localLayoutPoint) == StopHitTesting)

return true;

}