third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp - Issue 1630793002: Stop hit testing culled inlines when a match is found

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 1630793002: Stop hit testing culled inlines when a match is found (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simpler approach, but duplicated code Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/EllipsisBox.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

index e429394ba937ad898d7536e6d3bc5ee417789c8e..aa91d18d36577b9c44c3d6140016da8fa9d75c25 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

@@ -1046,11 +1046,11 @@ bool InlineFlowBox::nodeAtPoint(HitTestResult& result, const HitTestLocation& lo

flipForWritingMode(rect);

rect.moveBy(accumulatedOffset);

- // Pixel snap hit testing.

+ // Pixel snap hit testing.

rect = LayoutRect(pixelSnappedIntRect(rect));

if (visibleToHitTestRequest(result.hitTestRequest()) && locationInContainer.intersects(rect)) {

lineLayoutItem().updateHitTestResult(result, flipForWritingMode(locationInContainer.point() - toLayoutSize(accumulatedOffset))); // Don't add in m_topLeft here, we want coords in the containing block's space.

- if (!result.addNodeToListBasedTestResult(lineLayoutItem().node(), locationInContainer, rect))

+ if (result.addNodeToListBasedTestResult(lineLayoutItem().node(), locationInContainer, rect) == StopHitTesting)

return true;

}