Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1630783002: MIPS: Followup 'Introduce BUILTIN_CALL_PAIR.' (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Followup 'Introduce BUILTIN_CALL_PAIR.' Port 433e8848df4c7ec11b7b4a808f329f4a1e31142b Add DCHECK()s for BUILTIN_CALL, BUILTIN_CALL_PAIR to simulators. BUG= Committed: https://crrev.com/284a3456b9026a3623161366f684dadb74ed1663 Cr-Commit-Position: refs/heads/master@{#33500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/mips/simulator-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 11 months ago (2016-01-25 17:40:32 UTC) #2
MTBrandyberry
lgtm
4 years, 11 months ago (2016-01-25 18:06:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630783002/1
4 years, 11 months ago (2016-01-25 18:44:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 19:38:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 19:38:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/284a3456b9026a3623161366f684dadb74ed1663
Cr-Commit-Position: refs/heads/master@{#33500}

Powered by Google App Engine
This is Rietveld 408576698