Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1630693003: Fix offset issue of background-attachment:fixed on scroller (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 11 months ago
Reviewers:
pdr., trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix offset issue of background-attachment:fixed on scroller We should not include scroll offset of the scroller itself with the fixed background in http://crrev.com/cc8fa7dd73e. BUG=568625 TEST=paint/overflow/fixed-background-on-scroller-scroll.html Committed: https://crrev.com/70a919c39f5d644c7676f9c76686166826dccc8d Cr-Commit-Position: refs/heads/master@{#371310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
A + third_party/WebKit/LayoutTests/paint/overflow/fixed-background-on-scroller-scroll.html View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/overflow/fixed-background-on-scroller-scroll-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
4 years, 11 months ago (2016-01-25 18:35:45 UTC) #2
pdr.
LGTM
4 years, 11 months ago (2016-01-25 19:13:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630693003/1
4 years, 11 months ago (2016-01-25 19:43:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 20:54:35 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 20:55:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70a919c39f5d644c7676f9c76686166826dccc8d
Cr-Commit-Position: refs/heads/master@{#371310}

Powered by Google App Engine
This is Rietveld 408576698