third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h - Issue 1630683002: Canvas2d: addHitRegion() should take clipping region into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

Issue 1630683002: Canvas2d: addHitRegion() should take clipping region into account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-clip-test.html ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/ClipList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

index 25260c5d73d32e85a410ec018561abfd45794219..b5744182d311ab5387633ae9483f68c091628d8b 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

@@ -74,6 +74,7 @@ public:

bool hasClip() const { return m_hasClip; }

bool hasComplexClip() const { return m_hasComplexClip; }

void playbackClips(SkCanvas* canvas) const { m_clipList.playback(canvas); }

+ SkPath totalClipPath(const SkPath& path) const { return m_clipList.totalClipPath(path); }

Stephen White 2016/01/25 15:37:35 Naming nit: I think this function needs a verb, si

zino 2016/01/27 17:10:30 Done.

void setFont(const Font&, CSSFontSelector*);

const Font& font() const;