In case of an AuthException, start the recovery intent if it exists. This is a temporary fix to unb…

In case of an AuthException, start the recovery intent if it exists. This is a temporary fix to unblock devs while we work towards the real solution.

BUG=547048
Committed: https://crrev.com/6e7bc97a308959c65f768f10f95bc4700fb3d426
Cr-Commit-Position: refs/heads/master@{#371505}

[May, 2016-01-25 15:01:50]

maybelle@chromium.org changed reviewers:
+ bauerb@chromium.org, knn@chromium.org

[May, 2016-01-25 15:01:51]

Temporary fix for crbug/547048. PTAL!

[knn, 2016-01-25 15:08:25]

On 2016/01/25 15:01:51, May wrote:
> Temporary fix for crbug/547048. PTAL!

lgtm.

[knn, 2016-01-25 15:08:38]

https://codereview.chromium.org/1630673002/diff/1/sync/android/java/src/org/c...
File sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java
(right):

https://codereview.chromium.org/1630673002/diff/1/sync/android/java/src/org/c...
sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java:406:
Log.w(TAG, "Failed to perform auth task", ex);
I prefer Log.e but not strongly. I'll defer to Bernhard.

[Bernhard Bauer, 2016-01-25 16:31:23]

lgtm

https://codereview.chromium.org/1630673002/diff/1/sync/android/java/src/org/c...
File sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java
(right):

https://codereview.chromium.org/1630673002/diff/1/sync/android/java/src/org/c...
sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java:406:
Log.w(TAG, "Failed to perform auth task", ex);
On 2016/01/25 15:08:38, knn wrote:
> I prefer Log.e but not strongly. I'll defer to Bernhard.

I think Log.w is fine, as we are already doing something very visible here
anyway.

https://codereview.chromium.org/1630673002/diff/1/sync/android/java/src/org/c...
sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java:409: //
TODO(547048): Handle the recovery intent if it is present. For now, just
Nit: I think this is definitely handling the intent; it's just that we may want
to only do this once the user has chosen to recover from the error to prevent
spamming.

[May, 2016-01-25 16:42:57]

maybelle@chromium.org changed reviewers:
+ zea@chromium.org

[May, 2016-01-25 16:42:57]

zea@chromium.org: This is for crbug/547048

[Nicolas Zea, 2016-01-25 16:44:56]

LGTM, thanks!

[May, 2016-01-26 13:22:30]

The CQ bit was checked by maybelle@chromium.org

[May, 2016-01-26 13:22:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
knn@chromium.org, zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1630673002/#ps20001
(title: "Update comments")

[commit-bot: I haz the power, 2016-01-26 13:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630673002/20001

[commit-bot: I haz the power, 2016-01-26 14:12:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 14:13:51]

Description was changed from

==========
In case of an AuthException, start the recovery intent if it exists. This is a
temporary fix to unblock devs while we work towards the real solution.

BUG=547048
==========

to

==========
In case of an AuthException, start the recovery intent if it exists. This is a
temporary fix to unblock devs while we work towards the real solution.

BUG=547048

Committed: https://crrev.com/6e7bc97a308959c65f768f10f95bc4700fb3d426
Cr-Commit-Position: refs/heads/master@{#371505}
==========

[commit-bot: I haz the power, 2016-01-26 14:13:52]

Patchset 2 (id:??) landed as
https://crrev.com/6e7bc97a308959c65f768f10f95bc4700fb3d426
Cr-Commit-Position: refs/heads/master@{#371505}