src/runtime/runtime-strings.cc - Issue 1630633002: [regexp] correctly advance zero length matches for global/unicode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-strings.cc

Issue 1630633002: [regexp] correctly advance zero length matches for global/unicode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@backrefbounds

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/regexp/regexp-macro-assembler.h ('K') | « src/runtime/runtime-regexp.cc ('k') | test/mjsunit/harmony/unicode-regexp-zero-length.js » ('j') | test/mjsunit/harmony/unicode-regexp-zero-length.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/runtime/runtime-strings.cc

diff --git a/src/runtime/runtime-strings.cc b/src/runtime/runtime-strings.cc

index bd4dd699b4576363f7232380b75653e20863fce1..fcec47ddab314a74061a9dc4c11a3983f451ea08 100644

--- a/src/runtime/runtime-strings.cc

+++ b/src/runtime/runtime-strings.cc

@@ -341,7 +341,7 @@ RUNTIME_FUNCTION(Runtime_StringMatch) {

RUNTIME_ASSERT(regexp_info->HasFastObjectElements());

- RegExpImpl::GlobalCache global_cache(regexp, subject, true, isolate);

+ RegExpImpl::GlobalCache global_cache(regexp, subject, isolate);

if (global_cache.HasException()) return isolate->heap()->exception();

int capture_count = regexp->CaptureCount();