Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: src/regexp/jsregexp.h

Issue 1630633002: [regexp] correctly advance zero length matches for global/unicode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@backrefbounds
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/regexp/jsregexp.h
diff --git a/src/regexp/jsregexp.h b/src/regexp/jsregexp.h
index f4051fdf43d58e942cce6ba8ae0b340952539b7f..cd3932cb55e8f1b3c8aa81019548b24135aeebfa 100644
--- a/src/regexp/jsregexp.h
+++ b/src/regexp/jsregexp.h
@@ -121,7 +121,6 @@ class RegExpImpl {
public:
GlobalCache(Handle<JSRegExp> regexp,
Handle<String> subject,
- bool is_global,
Isolate* isolate);
INLINE(~GlobalCache());
@@ -137,6 +136,8 @@ class RegExpImpl {
INLINE(bool HasException()) { return num_matches_ < 0; }
private:
+ int AdvanceZeroLength(int last_index);
+
int num_matches_;
int max_matches_;
int current_match_index_;

Powered by Google App Engine
This is Rietveld 408576698