[regexp] correctly advance zero length matches for global/unicode.

[regexp] correctly advance zero length matches for global/unicode.

R=erik.corry@gmail.com
BUG=v8:2952
LOG=N

Committed: https://crrev.com/57d202d879dbf7589a7d2c1466b2698d3a2d9c21
Cr-Commit-Position: refs/heads/master@{#33550}

[Yang, 2016-01-27 10:20:46]

yangguo@chromium.org changed reviewers:
+ erikcorry@chromium.org

[Yang, 2016-01-27 10:20:46]

This should fix the zero-length match issues introduced by the stepping-back
patch.

[erikcorry, 2016-01-27 10:31:30]

erikcorry@google.com changed reviewers:
+ erikcorry@google.com

[erikcorry, 2016-01-27 10:31:31]

lgtm

https://codereview.chromium.org/1630633002/diff/1/src/regexp/regexp-macro-ass...
File src/regexp/regexp-macro-assembler.h (right):

https://codereview.chromium.org/1630633002/diff/1/src/regexp/regexp-macro-ass...
src/regexp/regexp-macro-assembler.h:167: GLOBAL_UNICODE
You need a warning here that the ordering of the modes is used in
global_with_zero_length_check

https://codereview.chromium.org/1630633002/diff/1/test/mjsunit/harmony/unicod...
File test/mjsunit/harmony/unicode-regexp-zero-length.js (right):

https://codereview.chromium.org/1630633002/diff/1/test/mjsunit/harmony/unicod...
test/mjsunit/harmony/unicode-regexp-zero-length.js:47: assertEquals(["","",""],
(L + T + L + T).match(u));
Try these last two again, but setting lastIndex to 1 instead of 2?

[Yang, 2016-01-27 12:19:14]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-01-27 12:19:14]

The patchset sent to the CQ was uploaded after l-g-t-m from erikcorry@google.com
Link to the patchset: https://codereview.chromium.org/1630633002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-01-27 12:19:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630633002/20001

[Yang, 2016-01-27 12:19:21]

https://codereview.chromium.org/1630633002/diff/1/src/regexp/regexp-macro-ass...
File src/regexp/regexp-macro-assembler.h (right):

https://codereview.chromium.org/1630633002/diff/1/src/regexp/regexp-macro-ass...
src/regexp/regexp-macro-assembler.h:167: GLOBAL_UNICODE
On 2016/01/27 10:31:31, erikcorry wrote:
> You need a warning here that the ordering of the modes is used in
> global_with_zero_length_check

I was thinking about adding a static check below, but then, the code added for
that could be better used to just do two compares. The C++ compiler can optimize
if it wants to.

https://codereview.chromium.org/1630633002/diff/1/test/mjsunit/harmony/unicod...
File test/mjsunit/harmony/unicode-regexp-zero-length.js (right):

https://codereview.chromium.org/1630633002/diff/1/test/mjsunit/harmony/unicod...
test/mjsunit/harmony/unicode-regexp-zero-length.js:47: assertEquals(["","",""],
(L + T + L + T).match(u));
On 2016/01/27 10:31:31, erikcorry wrote:
> Try these last two again, but setting lastIndex to 1 instead of 2?

Done.

[commit-bot: I haz the power, 2016-01-27 12:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 12:36:40]

Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/1981)
  v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Yang, 2016-01-27 12:49:08]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-01-27 12:49:08]

The patchset sent to the CQ was uploaded after l-g-t-m from erikcorry@google.com
Link to the patchset: https://codereview.chromium.org/1630633002/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-01-27 12:49:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630633002/40001

[commit-bot: I haz the power, 2016-01-27 13:08:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 13:09:09]

Description was changed from

==========
[regexp] correctly advance zero length matches for global/unicode.

R=erik.corry@gmail.com
BUG=v8:2952
LOG=N
==========

to

==========
[regexp] correctly advance zero length matches for global/unicode.

R=erik.corry@gmail.com
BUG=v8:2952
LOG=N

Committed: https://crrev.com/57d202d879dbf7589a7d2c1466b2698d3a2d9c21
Cr-Commit-Position: refs/heads/master@{#33550}
==========

[commit-bot: I haz the power, 2016-01-27 13:09:10]

Patchset 3 (id:??) landed as
https://crrev.com/57d202d879dbf7589a7d2c1466b2698d3a2d9c21
Cr-Commit-Position: refs/heads/master@{#33550}