Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1630583002: Split CSSPropertyParserTest into pieces (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split CSSPropertyParserTest into pieces After we enabled Oilpan, CSSPropertyParserTest started timeout on Windows Debug because it allocates a crazy number of CSS objects and causes many GCs. This CL splits the test into pieces so that each test doesn't hit the timeout. BUG=580999 Committed: https://crrev.com/644ce84d644644862c4c2e6ba3fc3be6eb946cc9 Cr-Commit-Position: refs/heads/master@{#371234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp View 2 chunks +128 lines, -33 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
lgtm add a sentence to the description explaining why?
4 years, 11 months ago (2016-01-25 12:01:23 UTC) #2
haraken
On 2016/01/25 12:01:23, sof wrote: > lgtm > > add a sentence to the description ...
4 years, 11 months ago (2016-01-25 12:01:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630583002/1
4 years, 11 months ago (2016-01-25 12:02:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 12:59:17 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 13:00:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/644ce84d644644862c4c2e6ba3fc3be6eb946cc9
Cr-Commit-Position: refs/heads/master@{#371234}

Powered by Google App Engine
This is Rietveld 408576698