Cleanup unref and null

Cleanup unref and null

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13457

[mtklein, 2014-02-14 15:02:23]

lgtm

[scroggo, 2014-02-14 15:07:40]

lgtm

Maybe we should add a test?

https://codereview.chromium.org/163053005/diff/1/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/163053005/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:167: SkSafeSetNull(clone->fRecord);
SkSafeSetNull seems like a bad name to me - it's not clear that it calls unref
as opposed to deleting it. Oh well, you didn't name this function.

[ian_cottrell, 2014-02-14 15:26:42]

The CQ bit was checked by iancottrell@chromium.org

[commit-bot: I haz the power, 2014-02-14 15:26:52]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/iancottrell@google.com/163053005/1

[ian_cottrell, 2014-02-14 15:32:03]

On 2014/02/14 15:07:40, scroggo wrote:
> lgtm
> 
> Maybe we should add a test?

Not sure what a useful test would be, it was redundant code with no visible side
effects.

> 
> https://codereview.chromium.org/163053005/diff/1/src/core/SkPicture.cpp
> File src/core/SkPicture.cpp (right):
> 
>
https://codereview.chromium.org/163053005/diff/1/src/core/SkPicture.cpp#newco...
> src/core/SkPicture.cpp:167: SkSafeSetNull(clone->fRecord);
> SkSafeSetNull seems like a bad name to me - it's not clear that it calls unref
> as opposed to deleting it. Oh well, you didn't name this function.

Yes, I agree, not sure what a good name would be though.

[commit-bot: I haz the power, 2014-02-14 17:27:12]

Change committed as 13457