Issue 163053004: Use NSS_ENABLE_ECC=1 for instrumented NSS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163053004: Use NSS_ENABLE_ECC=1 for instrumented NSS builds. (Closed)

Created:
6 years, 10 months ago by earthdok

Modified:
6 years, 10 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use NSS_ENABLE_ECC=1 for instrumented NSS builds. This more closely matches Ubuntu build options, and fixes at least some of NSS-related test failures. BUG=313751 TBR=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251318

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	third_party/instrumented_libraries/download_build_install.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/163053004/1

6 years, 10 months ago (2014-02-14 14:59:31 UTC) #3

earthdok

Committed patchset #1 manually as r251318 (presubmit successful).

6 years, 10 months ago (2014-02-14 15:07:47 UTC) #5

Alexander Potapenko

6 years, 10 months ago (2014-02-14 15:10:13 UTC) #6

LGTM

On Fri, Feb 14, 2014 at 7:07 AM,  <earthdok@chromium.org> wrote:
> Committed patchset #1 manually as r251318 (presubmit successful).
>
> https://codereview.chromium.org/163053004/

-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages