Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1630523002: [turbofan] Switch JSForInPrepare to %ForInPrepare style. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Switch JSForInPrepare to %ForInPrepare style. Now TurboFan always uses the newly introduced %ForInPrepare, no matter whether baseline is the interpreter or fullcodegen. For fullcodegen, we introduce a new PrepareId bailout point for this purpose. Drive-by-fix: Avoid the NoObservableSideEffectsScope in Crankshaft and use the PrepareId bailout point instead. R=jarin@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/825ece488b8343b4a8e3637130dfab9030844f34 Cr-Commit-Position: refs/heads/master@{#33480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -373 lines) Patch
M src/ast/ast.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -167 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +0 lines, -155 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +33 lines, -40 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-25 05:32:56 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the for-in unification for TurboFan (will cleanup runtime entry and typer in ...
4 years, 11 months ago (2016-01-25 05:48:36 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-25 05:54:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630523002/1
4 years, 11 months ago (2016-01-25 05:54:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 06:00:33 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 06:01:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/825ece488b8343b4a8e3637130dfab9030844f34
Cr-Commit-Position: refs/heads/master@{#33480}

Powered by Google App Engine
This is Rietveld 408576698