Fix HTTP response handling

Fix HTTP response handling

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23565

[Cutch, 2013-06-03 17:39:35]

Re: https://codereview.chromium.org/15736023/

[Søren Gjesse, 2013-06-03 19:06:06]

lgtm

However I have some additional questions related to the original change.

How does the Dart_RunLoop actually work? How does it ensure that the HTTP
response read?

I am not sure I understand the "The routine exits when all ports to the current
isolate are closed" comment for Dart_RunLoop. What happens if the isolate
calling spawnUri have other ports open (e.g. an open socket or a receive port
from it's parent isolate)?

In general shouldn't spawnUri return a future so that the HTTP operation can run
in the background?

Also should file:// Uris be supported?

https://codereview.chromium.org/16305011/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/16305011/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:298: Dart_Handle r = Dart_StringToCString(response,
&responseString);
Shouldn't this be Dart_StringToUTF8? E.g. what happens with the source 

main() => print("æøå");

?

https://codereview.chromium.org/16305011/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:320: result = Dart_ListGetAsBytes(response, 0, *buffer,
*buffer_len);
Does it make sense to handle the HTTP response with a content type which cannot
be translated to text?

[Cutch, 2013-06-03 20:03:20]

https://codereview.chromium.org/16305011/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/16305011/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:298: Dart_Handle r = Dart_StringToCString(response,
&responseString);
On 2013/06/03 19:06:06, Søren Gjesse wrote:
> Shouldn't this be Dart_StringToUTF8? E.g. what happens with the source 
> 
> main() => print("æøå");
> 
> ?

Done.

https://codereview.chromium.org/16305011/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:320: result = Dart_ListGetAsBytes(response, 0, *buffer,
*buffer_len);
On 2013/06/03 19:06:06, Søren Gjesse wrote:
> Does it make sense to handle the HTTP response with a content type which
cannot
> be translated to text?

Yes for a couple of reasons:

1) Loading snapshots which are binary.
2) Some HTTP servers serve *.dart files as binary, not as text.

[Cutch, 2013-06-03 20:31:06]

On 2013/06/03 19:06:06, Søren Gjesse wrote:
> lgtm
> 
> However I have some additional questions related to the original change.
> 
> How does the Dart_RunLoop actually work? How does it ensure that the HTTP
> response read?
> 

Dart_RunLoop won't return until the socket is closed.

> I am not sure I understand the "The routine exits when all ports to the
current
> isolate are closed" comment for Dart_RunLoop. What happens if the isolate
> calling spawnUri have other ports open (e.g. an open socket or a receive port
> from it's parent isolate)?
> 

We assert that this isn't the case before calling Dart_RunLoop().

[Cutch, 2013-06-03 20:32:24]

Committed patchset #2 manually as r23565 (presubmit successful).