dart:io | Improve NSS and SSL error messages for secure networking.

runtime/bin/secure_socket.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_SECURE_SOCKET_H_
 #define BIN_SECURE_SOCKET_H_
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
@@ skipping 17 matching lines @@
 static void ThrowException(const char* message) {
   Dart_Handle socket_io_exception =
       DartUtils::NewDartSocketIOException(message, Dart_Null());
   Dart_ThrowException(socket_io_exception);
 }
 
 
 /* Handle an error reported from the NSS library. */
 static void ThrowPRException(const char* message) {
   PRErrorCode error_code = PR_GetError();
-  int error_length = PR_GetErrorTextLength();
-  char* error_message = static_cast<char*>(malloc(error_length + 1));
-  ASSERT(error_message != NULL);
-  int copied_length = PR_GetErrorText(error_message);
-  ASSERT(copied_length == error_length);
-  error_message[error_length] = '\0';
+  const char* error_message = PR_ErrorToString(error_code, PR_LANGUAGE_EN);
   OSError os_error_struct(error_code, error_message, OSError::kNSS);
   Dart_Handle os_error = DartUtils::NewDartOSError(&os_error_struct);
   Dart_Handle socket_io_exception =
       DartUtils::NewDartSocketIOException(message, os_error);
-  free(error_message);
   Dart_ThrowException(socket_io_exception);
 }
 
 /*
  * SSLFilter encapsulates the NSS SSL(TLS) code in a filter, that communicates
  * with the containing _SecureFilterImpl Dart object through four shared
  * ExternalByteArray buffers, for reading and writing plaintext, and
  * reading and writing encrypted text.  The filter handles handshaking
  * and certificate verification.
  */
@@ skipping 65 matching lines @@
   void InitializeBuffers(Dart_Handle dart_this);
   void InitializePlatformData();
 
   DISALLOW_COPY_AND_ASSIGN(SSLFilter);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // BIN_SECURE_SOCKET_H_