[Mac] Fix BMB chevron button being black on Chrome open.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
 
 #include <stddef.h>
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/sdk_forward_declarations.h"
@@ skipping 847 matching lines @@
 
 // Configure the off-the-side button (e.g. specify the node range,
 // check if we should enable or disable it, etc).
 - (void)configureOffTheSideButtonContentsAndVisibility {
   [[offTheSideButton_ cell] setStartingChildIndex:displayedButtonCount_];
   [[offTheSideButton_ cell]
    setBookmarkNode:bookmarkModel_->bookmark_bar_node()];
   int bookmarkChildren = bookmarkModel_->bookmark_bar_node()->child_count();
   if (bookmarkChildren > displayedButtonCount_) {
     [offTheSideButton_ setHidden:NO];
+    [offTheSideButton_ setNeedsDisplay:YES];

[erikchen, 2016/01/25 14:51:05]

Does your CL still fix the problem if we only call setNeedsDisplay:  when hidden
changes from YES to NO? I'd prefer to minimize the extra redrawing that we do.

[Alexei Svitkine (slow), 2016/01/25 17:34:59]

Unfortunately, that doesn't work (on its own). The control starts visible, so
the initial time this happens the setHidden: above is a no-op.

However, I could set it to hidden in the initialization code above - i.e. after
line 429 and then the you suggest check can be added here. Would you like me to
do that?

   } else {
     // If we just deleted the last item in an off-the-side menu so the
     // button will be going away, make sure the menu goes away.
     if (folderController_ &&
         ([folderController_ parentButton] == offTheSideButton_))
       [self closeAllBookmarkFolders];
     // (And hide the button, too.)
     [offTheSideButton_ setHidden:YES];
   }
 }
@@ skipping 2062 matching lines @@
 - (id<BookmarkButtonControllerProtocol>)controllerForNode:
     (const BookmarkNode*)node {
   // See if it's in the bar, then if it is in the hierarchy of visible
   // folder menus.
   if (bookmarkModel_->bookmark_bar_node() == node)
     return self;
   return [folderController_ controllerForNode:node];
 }
 
 @end