Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4134)

Unified Diff: chrome/browser/web_applications/web_app_mac.h

Issue 16304005: Create a copy of each app's shim bundle in the app's app_data_path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/web_applications/web_app_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac.h
diff --git a/chrome/browser/web_applications/web_app_mac.h b/chrome/browser/web_applications/web_app_mac.h
index 676b20872badfb171ce62fa197b24a3fd63d1a50..e0ba9ab22c38cce9d45a35ab4f78b3252daf7336 100644
--- a/chrome/browser/web_applications/web_app_mac.h
+++ b/chrome/browser/web_applications/web_app_mac.h
@@ -33,10 +33,10 @@ void MaybeLaunchShortcut(const ShellIntegration::ShortcutInfo& shortcut_info);
class WebAppShortcutCreator {
public:
// Creates a new shortcut based on information in |shortcut_info|.
- // The shortcut stores its user data directory in |user_data_dir|.
+ // A copy of the shortcut is placed in |app_data_path|.
// |chrome_bundle_id| is the CFBundleIdentifier of the Chrome browser bundle.
WebAppShortcutCreator(
- const base::FilePath& user_data_dir,
+ const base::FilePath& app_data_path,
const ShellIntegration::ShortcutInfo& shortcut_info,
const string16& chrome_bundle_id);
@@ -69,11 +69,6 @@ class WebAppShortcutCreator {
// the app.
bool UpdateDisplayName(const base::FilePath& app_path) const;
- // Path to the app's user data directory. For example:
- // ~/Library/Application Support/Chromium/Default/Web Applications/_crx_abc/
- // Note, the user data directory is the parent of the profile directory.
- base::FilePath user_data_dir_;
-
// Returns the bundle identifier to use for this app bundle.
// |plist| is a dictionary containg a copy of the template plist file to
// be used for creating the app bundle.
@@ -83,6 +78,10 @@ class WebAppShortcutCreator {
virtual void RevealGeneratedBundleInFinder(
const base::FilePath& generated_bundle) const;
+ // Path to the data directory for this app. For example:
+ // ~/Library/Application Support/Chromium/Default/Web Applications/_crx_abc/
+ base::FilePath app_data_path_;
+
// Information about the app.
ShellIntegration::ShortcutInfo info_;
« no previous file with comments | « no previous file | chrome/browser/web_applications/web_app_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698