Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: gpu/command_buffer/service/sampler_manager.cc

Issue 1630263002: Revert of Updating texture validation to account for sampler objects in ES3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/sampler_manager.h" 5 #include "gpu/command_buffer/service/sampler_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "gpu/command_buffer/common/gles2_cmd_format.h" 9 #include "gpu/command_buffer/common/gles2_cmd_format.h"
10 #include "gpu/command_buffer/service/error_state.h" 10 #include "gpu/command_buffer/service/error_state.h"
11 #include "gpu/command_buffer/service/feature_info.h" 11 #include "gpu/command_buffer/service/feature_info.h"
12 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 12 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
13 #include "ui/gl/gl_bindings.h" 13 #include "ui/gl/gl_bindings.h"
14 #include "ui/gl/gl_context.h" 14 #include "ui/gl/gl_context.h"
15 #include "ui/gl/gl_fence.h" 15 #include "ui/gl/gl_fence.h"
16 #include "ui/gl/gpu_timing.h" 16 #include "ui/gl/gpu_timing.h"
17 17
18 namespace gpu { 18 namespace gpu {
19 namespace gles2 { 19 namespace gles2 {
20 20
21 SamplerState::SamplerState()
22 : min_filter(GL_NEAREST_MIPMAP_LINEAR),
23 mag_filter(GL_LINEAR),
24 wrap_r(GL_REPEAT),
25 wrap_s(GL_REPEAT),
26 wrap_t(GL_REPEAT),
27 compare_func(GL_LEQUAL),
28 compare_mode(GL_NONE),
29 max_lod(1000.0f),
30 min_lod(-1000.0f) {
31 }
32
33 Sampler::Sampler(SamplerManager* manager, GLuint service_id) 21 Sampler::Sampler(SamplerManager* manager, GLuint service_id)
34 : manager_(manager), 22 : manager_(manager),
35 service_id_(service_id), 23 service_id_(service_id),
24 min_filter_(GL_NEAREST_MIPMAP_LINEAR),
25 mag_filter_(GL_LINEAR),
26 wrap_r_(GL_REPEAT),
27 wrap_s_(GL_REPEAT),
28 wrap_t_(GL_REPEAT),
29 compare_func_(GL_LEQUAL),
30 compare_mode_(GL_NONE),
31 max_lod_(1000.0f),
32 min_lod_(-1000.0f),
36 deleted_(false) { 33 deleted_(false) {
37 DCHECK(manager); 34 DCHECK(manager);
38 } 35 }
39 36
40 Sampler::~Sampler() { 37 Sampler::~Sampler() {
41 if (manager_->have_context_) { 38 if (manager_->have_context_) {
42 glDeleteSamplers(1, &service_id_); 39 glDeleteSamplers(1, &service_id_);
43 } 40 }
44 } 41 }
45 42
46 GLenum Sampler::SetParameteri( 43 GLenum Sampler::SetParameteri(
47 const FeatureInfo* feature_info, GLenum pname, GLint param) { 44 const FeatureInfo* feature_info, GLenum pname, GLint param) {
48 DCHECK(feature_info); 45 DCHECK(feature_info);
49 46
50 switch (pname) { 47 switch (pname) {
51 case GL_TEXTURE_MIN_LOD: 48 case GL_TEXTURE_MIN_LOD:
52 case GL_TEXTURE_MAX_LOD: { 49 case GL_TEXTURE_MAX_LOD: {
53 GLfloat fparam = static_cast<GLfloat>(param); 50 GLfloat fparam = static_cast<GLfloat>(param);
54 return SetParameterf(feature_info, pname, fparam); 51 return SetParameterf(feature_info, pname, fparam);
55 } 52 }
56 case GL_TEXTURE_MIN_FILTER: 53 case GL_TEXTURE_MIN_FILTER:
57 if (!feature_info->validators()->texture_min_filter_mode.IsValid(param)) { 54 if (!feature_info->validators()->texture_min_filter_mode.IsValid(param)) {
58 return GL_INVALID_ENUM; 55 return GL_INVALID_ENUM;
59 } 56 }
60 sampler_state_.min_filter = param; 57 min_filter_ = param;
61 break; 58 break;
62 case GL_TEXTURE_MAG_FILTER: 59 case GL_TEXTURE_MAG_FILTER:
63 if (!feature_info->validators()->texture_mag_filter_mode.IsValid(param)) { 60 if (!feature_info->validators()->texture_mag_filter_mode.IsValid(param)) {
64 return GL_INVALID_ENUM; 61 return GL_INVALID_ENUM;
65 } 62 }
66 sampler_state_.mag_filter = param; 63 mag_filter_ = param;
67 break; 64 break;
68 case GL_TEXTURE_WRAP_R: 65 case GL_TEXTURE_WRAP_R:
69 if (!feature_info->validators()->texture_wrap_mode.IsValid(param)) { 66 if (!feature_info->validators()->texture_wrap_mode.IsValid(param)) {
70 return GL_INVALID_ENUM; 67 return GL_INVALID_ENUM;
71 } 68 }
72 sampler_state_.wrap_r = param; 69 wrap_r_ = param;
73 break; 70 break;
74 case GL_TEXTURE_WRAP_S: 71 case GL_TEXTURE_WRAP_S:
75 if (!feature_info->validators()->texture_wrap_mode.IsValid(param)) { 72 if (!feature_info->validators()->texture_wrap_mode.IsValid(param)) {
76 return GL_INVALID_ENUM; 73 return GL_INVALID_ENUM;
77 } 74 }
78 sampler_state_.wrap_s = param; 75 wrap_s_ = param;
79 break; 76 break;
80 case GL_TEXTURE_WRAP_T: 77 case GL_TEXTURE_WRAP_T:
81 if (!feature_info->validators()->texture_wrap_mode.IsValid(param)) { 78 if (!feature_info->validators()->texture_wrap_mode.IsValid(param)) {
82 return GL_INVALID_ENUM; 79 return GL_INVALID_ENUM;
83 } 80 }
84 sampler_state_.wrap_t = param; 81 wrap_t_ = param;
85 break; 82 break;
86 case GL_TEXTURE_COMPARE_FUNC: 83 case GL_TEXTURE_COMPARE_FUNC:
87 if (!feature_info->validators()->texture_compare_func.IsValid(param)) { 84 if (!feature_info->validators()->texture_compare_func.IsValid(param)) {
88 return GL_INVALID_ENUM; 85 return GL_INVALID_ENUM;
89 } 86 }
90 sampler_state_.compare_func = param; 87 compare_func_ = param;
91 break; 88 break;
92 case GL_TEXTURE_COMPARE_MODE: 89 case GL_TEXTURE_COMPARE_MODE:
93 if (!feature_info->validators()->texture_compare_mode.IsValid(param)) { 90 if (!feature_info->validators()->texture_compare_mode.IsValid(param)) {
94 return GL_INVALID_ENUM; 91 return GL_INVALID_ENUM;
95 } 92 }
96 sampler_state_.compare_mode = param; 93 compare_mode_ = param;
97 break; 94 break;
98 default: 95 default:
99 return GL_INVALID_ENUM; 96 return GL_INVALID_ENUM;
100 } 97 }
101 return GL_NO_ERROR; 98 return GL_NO_ERROR;
102 } 99 }
103 100
104 GLenum Sampler::SetParameterf( 101 GLenum Sampler::SetParameterf(
105 const FeatureInfo* feature_info, GLenum pname, GLfloat param) { 102 const FeatureInfo* feature_info, GLenum pname, GLfloat param) {
106 switch (pname) { 103 switch (pname) {
107 case GL_TEXTURE_MIN_FILTER: 104 case GL_TEXTURE_MIN_FILTER:
108 case GL_TEXTURE_MAG_FILTER: 105 case GL_TEXTURE_MAG_FILTER:
109 case GL_TEXTURE_WRAP_R: 106 case GL_TEXTURE_WRAP_R:
110 case GL_TEXTURE_WRAP_S: 107 case GL_TEXTURE_WRAP_S:
111 case GL_TEXTURE_WRAP_T: 108 case GL_TEXTURE_WRAP_T:
112 case GL_TEXTURE_COMPARE_FUNC: 109 case GL_TEXTURE_COMPARE_FUNC:
113 case GL_TEXTURE_COMPARE_MODE: { 110 case GL_TEXTURE_COMPARE_MODE: {
114 GLint iparam = static_cast<GLint>(param); 111 GLint iparam = static_cast<GLint>(param);
115 return SetParameteri(feature_info, pname, iparam); 112 return SetParameteri(feature_info, pname, iparam);
116 } 113 }
117 case GL_TEXTURE_MIN_LOD: 114 case GL_TEXTURE_MIN_LOD:
118 sampler_state_.min_lod = param; 115 min_lod_ = param;
119 break; 116 break;
120 case GL_TEXTURE_MAX_LOD: 117 case GL_TEXTURE_MAX_LOD:
121 sampler_state_.max_lod = param; 118 max_lod_ = param;
122 break; 119 break;
123 default: 120 default:
124 return GL_INVALID_ENUM; 121 return GL_INVALID_ENUM;
125 } 122 }
126 return GL_NO_ERROR; 123 return GL_NO_ERROR;
127 } 124 }
128 125
129 SamplerManager::SamplerManager(FeatureInfo* feature_info) 126 SamplerManager::SamplerManager(FeatureInfo* feature_info)
130 : feature_info_(feature_info), 127 : feature_info_(feature_info),
131 have_context_(true) { 128 have_context_(true) {
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 ERRORSTATE_SET_GL_ERROR_INVALID_PARAMI( 197 ERRORSTATE_SET_GL_ERROR_INVALID_PARAMI(
201 error_state, result, function_name, pname, param); 198 error_state, result, function_name, pname, param);
202 } 199 }
203 } else { 200 } else {
204 glSamplerParameterf(sampler->service_id(), pname, param); 201 glSamplerParameterf(sampler->service_id(), pname, param);
205 } 202 }
206 } 203 }
207 204
208 } // namespace gles2 205 } // namespace gles2
209 } // namespace gpu 206 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/sampler_manager.h ('k') | gpu/command_buffer/service/texture_definition.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698