Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chromeos/ime/composition_text_unittest.cc

Issue 163023002: Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit test compile Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/ime/composition_text.h ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/composition_text_unittest.cc
diff --git a/chromeos/ime/composition_text_unittest.cc b/chromeos/ime/composition_text_unittest.cc
index 0dbe6cd017bbe46e60aff34bb21a639922bbb90f..68f034291911afb9417d2270b0a55d0aa0fcf30b 100644
--- a/chromeos/ime/composition_text_unittest.cc
+++ b/chromeos/ime/composition_text_unittest.cc
@@ -5,12 +5,13 @@
#include "chromeos/ime/composition_text.h"
+#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
TEST(CompositionTextTest, CopyTest) {
- const char kSampleText[] = "Sample Text";
+ const base::string16 kSampleText = base::UTF8ToUTF16("Sample Text");
const CompositionText::UnderlineAttribute kSampleUnderlineAttribute1 = {
CompositionText::COMPOSITION_TEXT_UNDERLINE_SINGLE, 10, 20};
« no previous file with comments | « chromeos/ime/composition_text.h ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698