analyzer_experimental snapshot

editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/BreadthFirstVisitor.java

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/BreadthFirstVisitor.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/BreadthFirstVisitor.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/BreadthFirstVisitor.java
index 184072d3f002b5bdad7a1712e7b9d88f0300de48..1a90b7d7f1ebedfab5d05dc2ca2a817af85f5bf4 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/BreadthFirstVisitor.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/BreadthFirstVisitor.java
@@ -16,7 +16,6 @@ package com.google.dart.engine.ast.visitor;
 import com.google.dart.engine.ast.ASTNode;
 
 import java.util.LinkedList;
-import java.util.List;
 
 /**
  * Instances of the class {@code BreadthFirstVisitor} implement an AST visitor that will recursively
@@ -27,8 +26,7 @@ import java.util.List;
  * @coverage dart.engine.ast
  */
 public class BreadthFirstVisitor<R> extends GeneralizingASTVisitor<R> {
-
-  private List<ASTNode> queue = createQueue();
+  private final LinkedList<ASTNode> queue = new LinkedList<ASTNode>();

[Brian Wilkerson, 2013/06/01 19:46:58]

createQueue might have been defined in order to allow subclasses to override it.
I've added Steve as a reviewer.

[messick, 2013/06/01 21:32:10]

Just so. Why delete it?

 
   private GeneralizingASTVisitor<Void> childVisitor = new GeneralizingASTVisitor<Void>() {
     @Override
@@ -46,7 +44,7 @@ public class BreadthFirstVisitor<R> extends GeneralizingASTVisitor<R> {
   public void visitAllNodes(ASTNode root) {
     queue.add(root);
     while (!queue.isEmpty()) {
-      ASTNode next = queue.remove(0);
+      ASTNode next = queue.removeFirst();

[messick, 2013/06/01 21:32:10]

None of these changes are needed, unless this is showing up in performance
profiling.

[scheglov, 2013/06/01 22:12:04]

In Dart there are no direct replacement for LinkedList.
The closest analog is Queue, but it is not the List.

So, there are two options:
1. implement JavaLinkedList;
2. change code to use Queue compatible API.

I've checked that there are no overrides for createQueue().
And actually we don't need List here, we need a queue.
So, I've thought that it is better to change this class.

       next.accept(this);
     }
   }
@@ -56,8 +54,4 @@ public class BreadthFirstVisitor<R> extends GeneralizingASTVisitor<R> {
     node.visitChildren(childVisitor);
     return null;
   }
-
-  protected List<ASTNode> createQueue() {
-    return new LinkedList<ASTNode>();
-  }
 }