Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 163013002: [Identity] Use const ref on ExtensionTokenKey parameter (Closed)

Created:
6 years, 10 months ago by tzik
Modified:
6 years, 10 months ago
Reviewers:
Michael Courage
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

[Identity] Use const ref on ExtensionTokenKey parameter Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/api/identity/extension_token_key.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/extension_token_key.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
Hi, Michael. Can I make a drive-by fix?
6 years, 10 months ago (2014-02-13 08:18:13 UTC) #1
Michael Courage
On 2014/02/13 08:18:13, tzik wrote: > Hi, Michael. > Can I make a drive-by fix? ...
6 years, 10 months ago (2014-02-13 17:35:53 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 10 months ago (2014-02-14 03:11:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/163013002/1
6 years, 10 months ago (2014-02-14 03:13:26 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 07:24:14 UTC) #5
Message was sent while issue was closed.
Change committed as 251268

Powered by Google App Engine
This is Rietveld 408576698