Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 16300009: remove webkit.gyp (and the test_shell target) and update affected targets (Closed)

Created:
7 years, 6 months ago by Dirk Pranke
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

remove webkit.gyp (and the test_shell target) and update affected targets We had some old dummy targets left over in webkit.gyp that were used when we had to jump through hoops to build webkit-related targets. We don't need these any more. We also don't need the dummy test_shell target, as no builder should be trying to build test_shell directly at this point. R=darin@chromium.org, jamesr@chromium.org BUG=247105 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204565

Patch Set 1 #

Patch Set 2 : try again #

Patch Set 3 : fix missing commas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -63 lines) Patch
build/all.gyp View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
webkit/support/test_shell_dummy.cc View 1 chunk +0 lines, -7 lines 0 comments Download
webkit/webkit.gyp View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
7 years, 6 months ago (2013-06-05 19:37:58 UTC) #1
jamesr
lgtm
7 years, 6 months ago (2013-06-05 19:42:18 UTC) #2
Dirk Pranke
darin, get I get approval to delete the rest of test_shell :) ?
7 years, 6 months ago (2013-06-06 00:41:08 UTC) #3
darin (slow to review)
On 2013/06/06 00:41:08, Dirk Pranke wrote: > darin, get I get approval to delete the ...
7 years, 6 months ago (2013-06-06 07:44:14 UTC) #4
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-06 07:44:28 UTC) #5
Dirk Pranke
7 years, 6 months ago (2013-06-06 20:05:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r204565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698