Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1629963005:
Add new media image layout tests for video color profiles (Closed)
|
Created:
4 years, 11 months ago by Noel Gordon Modified:
4 years, 11 months ago CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org, philipj_slow, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, radu.velea, robert.bradford, Justin Novosad Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd new media image layout tests for video color profiles
media/color-profile-munsell-bt601-smpte-to-srgb.html
media/color-profile-munsell-bt709-to-srgb.html
The tests transform a test chart image from source color profile
(bt601, bt709) to sRGB and compares the output with the expected
Munsell colors [1] and studio video range black and white colors
and some proportions of them, SG Black 2x for example. Note: all
the expected colors are in sRGB color space.
The tests (one each for bt601 & bt709) are designed to be run in
the test harness automatically, but also manually to help detect
color changes should that happen in future.
The tabulated color results of these tests are correct and don't
change or need to be rebaselined. If the test colors changed, it
is a colorimetric error: the offending CL should be reverted.
[1] For more details on Munsell colors and gamuts, see
http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html
TBR=kbr@chomium.org
BUG=570150
Committed: https://crrev.com/eec72142e952022f7c4891f667768195b8b4be54
Cr-Commit-Position: refs/heads/master@{#371589}
Patch Set 1 #Patch Set 2 : Patch for landing #
Messages
Total messages: 28 (18 generated)
Description was changed from ========== Add new media image layuot tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt790) to sRGB, and compare the output expected with the Munsell colors [1] and Studio range video black and white colors of the test chart. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt790) to sRGB, and compare the output expected with the Munsell colors [1] and Studio range video black and white colors of the test chart. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt790) to sRGB, and compare the output expected with the Munsell colors [1] and Studio range video black and white colors of the test chart. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt790) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors of the test chart. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results of the tests are correct, and should never change or be rebaselined. If the colors changed, that is a colorimetric error and the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt790) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors of the test chart. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results of the tests are correct, and should never change or be rebaselined. If the colors changed, that is a colorimetric error and the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results of the tests are correct, and should never change or be rebaselined. If the colors changed, that is a colorimetric error and the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results of the tests are correct, and should never change or be rebaselined. If the colors changed, that is a colorimetric error and the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error and the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error and the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and Studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and studio-range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
noel@chromium.org changed reviewers: + kbr@chromium.org
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and studio-range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629963005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629963005/20001
noel@chromium.org changed reviewers: + enne@chromium.org
Ken may be away on Khronos work. enne@ could you review please?
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB, and compare the output with the expected Munsell colors [1] and studio range video black and white colors in sRGB. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ==========
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 ==========
The CQ bit was unchecked by noel@chromium.org
The CQ bit was checked by noel@chromium.org
Layout tests passing.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629963005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629963005/20001
Message was sent while issue was closed.
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 Committed: https://crrev.com/eec72142e952022f7c4891f667768195b8b4be54 Cr-Commit-Position: refs/heads/master@{#371589} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eec72142e952022f7c4891f667768195b8b4be54 Cr-Commit-Position: refs/heads/master@{#371589}
Message was sent while issue was closed.
LGTM though I'm not an expert in this area. Would be ideal to get a domain expert to co-review CLs like this one.
Message was sent while issue was closed.
Thanks Ken. I would normally ask Justin who has some domain expertise, but he is out at the moment. Added him as a reviewer post-facto.
Message was sent while issue was closed.
Description was changed from ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 Committed: https://crrev.com/eec72142e952022f7c4891f667768195b8b4be54 Cr-Commit-Position: refs/heads/master@{#371589} ========== to ========== Add new media image layout tests for video color profiles media/color-profile-munsell-bt601-smpte-to-srgb.html media/color-profile-munsell-bt709-to-srgb.html The tests transform a test chart image from source color profile (bt601, bt709) to sRGB and compares the output with the expected Munsell colors [1] and studio video range black and white colors and some proportions of them, SG Black 2x for example. Note: all the expected colors are in sRGB color space. The tests (one each for bt601 & bt709) are designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The tabulated color results of these tests are correct and don't change or need to be rebaselined. If the test colors changed, it is a colorimetric error: the offending CL should be reverted. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html TBR=kbr@chomium.org BUG=570150 Committed: https://crrev.com/eec72142e952022f7c4891f667768195b8b4be54 Cr-Commit-Position: refs/heads/master@{#371589} ==========
Message was sent while issue was closed.
noel@chromium.org changed reviewers: + junov@chromium.org
Message was sent while issue was closed.
Filed issue https://code.google.com/p/chromium/issues/detail?id=581500, the rebaseline server seems inactive. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
