Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 16299005: Make chromium_builder_tests depend on all_blink (Closed)

Created:
7 years, 6 months ago by jamesr
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Make chromium_builder_tests depend on all_blink This is necessary so chromium buildbots and tryservers can run blink's unit tests. BUG=248008 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
7 years, 6 months ago (2013-06-10 17:31:47 UTC) #1
Nico
lgtm Please watch http://build.chromium.org/p/tryserver.chromium/stats after this lands and see if compile time goes up considerably
7 years, 6 months ago (2013-06-10 17:33:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16299005/1
7 years, 6 months ago (2013-06-10 17:33:28 UTC) #3
jamesr
On 2013/06/10 17:33:11, Nico wrote: > lgtm > > Please watch http://build.chromium.org/p/tryserver.chromium/stats after this > ...
7 years, 6 months ago (2013-06-10 17:34:11 UTC) #4
jamesr
7 years, 6 months ago (2013-06-10 17:52:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r205242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698