Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 16299003: Revert 203587 "Move CheckInstall to device status and fail on lo..." (Closed)

Created:
7 years, 6 months ago by justinlin
Modified:
7 years, 6 months ago
Reviewers:
navabi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 203587 "Move CheckInstall to device status and fail on lo..." Broke android tests. > Move CheckInstall to device status and fail on low install speed and battery. > > Removes the recently added CheckInstall step and moves the checking to the > device status check step. Recently, devices will install very slowly causing > tests to fail with device problems. We have also seen battery issues. The new > device status check step will fail if any devices install unreasonably slow > (i.e. < 800 KB/s) or have critically low battery level (i.e. < 5%). > > BUG=230970, 224004, 242237 > > Review URL: https://chromiumcodereview.appspot.com/16110005 TBR=navabi@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M trunk/src/build/android/buildbot/bb_device_steps.py View 2 chunks +12 lines, -0 lines 0 comments Download
M trunk/src/build/android/device_status_check.py View 5 chunks +4 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
justinlin
7 years, 6 months ago (2013-06-01 06:42:11 UTC) #1
justinlin
Committed patchset #1 manually as r203594.
7 years, 6 months ago (2013-06-01 06:42:16 UTC) #2
justinlin
7 years, 6 months ago (2013-06-01 06:43:11 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698