Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 162983003: Internalize string keys in Keyed{Store,Load}IC. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Internalize string keys in Keyed{Store,Load}IC. R=jkummerow@chromium.org BUG=v8:3144 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 10 months ago (2014-02-13 08:34:57 UTC) #1
Jakob Kummerow
lgtm
6 years, 10 months ago (2014-02-13 08:43:27 UTC) #2
Yang
6 years, 10 months ago (2014-02-13 08:44:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698