Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 16298005: Remove Battery Status API support code from Blink (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, abarth-chromium, ojan
Visibility:
Public.

Description

Remove Battery Status API support code from Blink The code was already disabled by a compile-time flag. Given that there are concerns about the API, and that there's no current plan to enable the code, delete it for now. See attached bug for more discussion. R=abarth@chromium.org BUG=122593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1395 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/batterystatus/add-listener-from-callback.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/add-listener-from-callback-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/batterystatus/basic-all-types-of-events.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/basic-all-types-of-events-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/batterystatus/basic-operation.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/basic-operation-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/batterystatus/multiple-frames.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/multiple-frames-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/add-listener-from-callback.js View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/basic-all-types-of-events.js View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/basic-operation.js View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/multiple-frames.js View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/updates.js View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/window-property.js View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/batterystatus/updates.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/updates-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/batterystatus/window-property.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/window-property-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/WebKit/chromium/WebKit.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
D Source/WebKit/chromium/public/WebBatteryStatus.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/WebKit/chromium/public/WebBatteryStatusClient.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/WebKit/chromium/src/BatteryClientImpl.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/WebKit/chromium/src/BatteryClientImpl.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 5 chunks +0 lines, -17 lines 0 comments Download
M Source/core/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/modules/battery/BatteryClient.h View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/modules/battery/BatteryController.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/modules/battery/BatteryController.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
D Source/modules/battery/BatteryManager.h View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/modules/battery/BatteryManager.cpp View 1 chunk +0 lines, -107 lines 0 comments Download
D Source/modules/battery/BatteryManager.idl View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/modules/battery/BatteryStatus.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/modules/battery/BatteryStatus.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/modules/battery/NavigatorBattery.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/modules/battery/NavigatorBattery.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/modules/battery/NavigatorBattery.idl View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +0 lines, -11 lines 0 comments Download
D public/webview/WebBatteryStatus.h View 1 chunk +0 lines, -51 lines 0 comments Download
D public/webview/WebBatteryStatusClient.h View 1 chunk +0 lines, -41 lines 0 comments Download
M public/webview/WebView.h View 2 chunks +0 lines, -8 lines 0 comments Download
M public/webview/WebViewClient.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
adamk
7 years, 6 months ago (2013-06-06 23:23:17 UTC) #1
abarth-chromium
lgtm
7 years, 6 months ago (2013-06-06 23:35:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/16298005/1
7 years, 6 months ago (2013-06-06 23:41:07 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=9128
7 years, 6 months ago (2013-06-07 04:18:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/16298005/1
7 years, 6 months ago (2013-06-07 15:32:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for public/webview/WebView.h: While running patch -p1 --forward --force --no-backup-if-mismatch; A public/webview ...
7 years, 6 months ago (2013-06-07 15:33:01 UTC) #6
adamk
7 years, 6 months ago (2013-06-07 15:48:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r152030 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698