Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1629733002: net: move IsHostnameNonUnique() into url_util.h (Closed)

Created:
4 years, 11 months ago by tfarina
Modified:
4 years, 11 months ago
Reviewers:
eroman, felt
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: move IsHostnameNonUnique() into url_util.h This patch moves this free function from generic net_util.h header, into url_util.h, because it operates on a URL part (hostname), so it seems more appropriate there than in the soon-to-go-way net_util.h. BUG=488531 TEST=net_unittests --gtest_filter=UrlUtil* R=eroman@chromium.org TBR=felt@chromium.org Committed: https://crrev.com/3ad1745a8c5ac1e18edb3b7ffe3ce1b792feb341 Cr-Commit-Position: refs/heads/master@{#371768}

Patch Set 1 #

Patch Set 2 : fix ssl_errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -156 lines) Patch
M components/ssl_errors/error_classification.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +0 lines, -49 lines 0 comments Download
M net/base/net_util_unittest.cc View 2 chunks +0 lines, -100 lines 0 comments Download
M net/base/url_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/url_util.cc View 2 chunks +48 lines, -1 line 0 comments Download
M net/base/url_util_unittest.cc View 2 chunks +81 lines, -0 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
tfarina
4 years, 11 months ago (2016-01-23 20:06:08 UTC) #1
eroman
lgtm
4 years, 11 months ago (2016-01-26 22:34:05 UTC) #2
tfarina
TBRing Adrienne for ssl_errors.
4 years, 11 months ago (2016-01-27 09:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629733002/20001
4 years, 11 months ago (2016-01-27 09:21:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 10:34:45 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3ad1745a8c5ac1e18edb3b7ffe3ce1b792feb341 Cr-Commit-Position: refs/heads/master@{#371768}
4 years, 11 months ago (2016-01-27 10:35:45 UTC) #11
felt
4 years, 11 months ago (2016-01-27 15:15:58 UTC) #12
Message was sent while issue was closed.
ssl_errors/ lgtm

Powered by Google App Engine
This is Rietveld 408576698