Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: courgette/encoded_program_fuzz_unittest.cc

Issue 1629703002: [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments and includes. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/encoded_program_fuzz_unittest.cc
diff --git a/courgette/encoded_program_fuzz_unittest.cc b/courgette/encoded_program_fuzz_unittest.cc
index b755f857c897b4cb49d45f611c2130b7fb46e452..a4a55e78d856f12459fc148397c51ba62064b630 100644
--- a/courgette/encoded_program_fuzz_unittest.cc
+++ b/courgette/encoded_program_fuzz_unittest.cc
@@ -10,13 +10,15 @@
//
// We try a lot of arbitrary modifications to the serialized form and make sure
// that the outcome is not a crash.
-
-#include "base/test/test_suite.h"
+#include "courgette/encoded_program.h"
#include <stddef.h>
+#include "base/memory/scoped_ptr.h"
+#include "base/test/test_suite.h"
#include "courgette/base_test_unittest.h"
#include "courgette/courgette.h"
+#include "courgette/program_detector.h"
#include "courgette/streams.h"
class DecodeFuzzTest : public BaseTest {
@@ -40,24 +42,24 @@ void DecodeFuzzTest::FuzzExe(const char* file_name) const {
const void* original_buffer = file1.c_str();
size_t original_length = file1.length();
- courgette::AssemblyProgram* program = NULL;
+ scoped_ptr<courgette::AssemblyProgram> program;
const courgette::Status parse_status =
courgette::ParseDetectedExecutable(original_buffer, original_length,
&program);
EXPECT_EQ(courgette::C_OK, parse_status);
- courgette::EncodedProgram* encoded = NULL;
-
- const courgette::Status encode_status = Encode(program, &encoded);
+ scoped_ptr<courgette::EncodedProgram> encoded;
+ const courgette::Status encode_status = Encode(*program, &encoded);
EXPECT_EQ(courgette::C_OK, encode_status);
- DeleteAssemblyProgram(program);
+ program.reset(nullptr);
courgette::SinkStreamSet sinks;
- const courgette::Status write_status = WriteEncodedProgram(encoded, &sinks);
+ const courgette::Status write_status =
+ WriteEncodedProgram(encoded.get(), &sinks);
EXPECT_EQ(courgette::C_OK, write_status);
- DeleteEncodedProgram(encoded);
+ encoded.reset(nullptr);
courgette::SinkStream sink;
bool can_collect = sinks.CopyTo(&sink);
@@ -170,7 +172,7 @@ void DecodeFuzzTest::FuzzBits(const std::string& base_buffer,
bool DecodeFuzzTest::TryAssemble(const std::string& buffer,
std::string* output) const {
- courgette::EncodedProgram *encoded = NULL;
+ scoped_ptr<courgette::EncodedProgram> encoded;
bool result = false;
courgette::SourceStreamSet sources;
@@ -180,7 +182,8 @@ bool DecodeFuzzTest::TryAssemble(const std::string& buffer,
ReadEncodedProgram(&sources, &encoded);
if (read_status == courgette::C_OK) {
courgette::SinkStream assembled;
- const courgette::Status assemble_status = Assemble(encoded, &assembled);
+ const courgette::Status assemble_status =
+ Assemble(encoded.get(), &assembled);
if (assemble_status == courgette::C_OK) {
const void* assembled_buffer = assembled.Buffer();
@@ -194,8 +197,6 @@ bool DecodeFuzzTest::TryAssemble(const std::string& buffer,
}
}
- DeleteEncodedProgram(encoded);
-
return result;
}

Powered by Google App Engine
This is Rietveld 408576698