JSON export/import in generate-bindings.pl

Source/bindings/scripts/generate-bindings.pl

 #!/usr/bin/perl -w
 #
 # Copyright (C) 2005 Apple Computer, Inc.
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # 
 # This file is part of WebKit
 # 
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Library General Public
 # License as published by the Free Software Foundation; either
@@ skipping 20 matching lines @@
 use strict;
 
 use File::Path;
 use File::Basename;
 use Getopt::Long;
 use Text::ParseWords;
 use Cwd;
 
 use IDLParser;
 use CodeGeneratorV8;
+use JSONSerializer;
 
 my @idlDirectories;
 my $outputDirectory;
 my $outputHeadersDirectory;
 my $defines;
 my $filename;
 my $preprocessor;
 my $verbose;
 my $supplementalDependencyFile;
 my $additionalIdlFiles;
@@ skipping 126 matching lines @@
                     $constant->extendedAttributes->{$extendedAttributeName} = $interface->extendedAttributes->{$extendedAttributeName};
                 }
                 push(@{$targetDataNode->constants}, $constant);
             }
         } else {
             die "$idlFile is not a supplemental dependency of $targetIdlFile. There maybe a bug in the the supplemental dependency generator (preprocess_idls.py).\n";
         }
     }
 }
 
+# FIXME: This code will be removed once IDLParser.pm and CodeGeneratorV8.pm

[dominicc (has gone to gerrit), 2013/06/12 04:39:33]

Good.

+# are connected via JSON files. See http://crbug.com/242795
+$targetDocument = deserializeJSON(serializeJSON($targetDocument));
+
 # Generate desired output for the target IDL file.

[dominicc (has gone to gerrit), 2013/06/12 04:39:33]

Is it possible to chop this up with functions or modules so that we know exactly
what data the following steps depends on? The above code sets up a bunch of
state and that is intertwined with parsing, which is not what we want.

I'm fine if that is in a follow-up changelist. But if so it would be nice to
have a separate refactoring patch that focuses specifically on that.

[Nils Barth (inactive), 2013/06/12 09:15:27]

Agreed.
I'd be happy to do a follow-up refactoring CL.
Alternatively, we could do it when we change the build,
as we'll be changing the flow then, and possibly breaking this script up into
two pieces (which would disentangle these pretty clearly).

Haraken?

 my @dependentIdlFiles = ($targetDocument->fileName(), @supplementedIdlFiles);
 my $codeGenerator = CodeGeneratorV8->new($targetDocument, \@idlDirectories, $preprocessor, $defines, $verbose, \@dependentIdlFiles, $writeFileOnlyIfChanged);
 my $interfaces = $targetDocument->interfaces;
 foreach my $interface (@$interfaces) {
     print "Generating bindings code for IDL interface \"" . $interface->name . "\"...\n" if $verbose;
     $codeGenerator->GenerateInterface($interface);
     $codeGenerator->WriteData($interface, $outputDirectory, $outputHeadersDirectory);
 }
 
 sub generateEmptyHeaderAndCpp
@@ skipping 93 matching lines @@
                 last OUTER;
             }
         }
     }
     if ($error) {
         die "IDL ATTRIBUTE CHECKER ERROR: $error
 If you want to add a new IDL attribute, you need to add it to bindings/scripts/IDLAttributes.txt and add explanations to the Blink IDL document (http://chromium.org/blink/webidl).
 ";
     }
 }