List constructor sentinel must not implement 'int'

List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for type inference and generated code quality.

To get this to work required fixes in type inference and the collection of reified default argument values.

Fixes issue https://github.com/dart-lang/sdk/issues/25566

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a01c6a1cfacb1013e8acca2bc7422dfb5c8c408

[sra1, 2016-01-22 22:45:49]

Patchset #1 (id:1) has been deleted

[sra1, 2016-01-22 22:47:20]

Description was changed from

==========
List constructor sentinel must not implement 'int'
==========

to

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.
==========

[sra1, 2016-01-22 22:47:20]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-01-22 22:58:54]

lgtm

https://codereview.chromium.org/1629553002/diff/2/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_array.dart (right):

https://codereview.chromium.org/1629553002/diff/2/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_array.dart:10: const
_ListConstructorSentinel = const _Growable();
nit: lowercase L (_listConstructorSentinel)

[sra1, 2016-01-23 02:39:29]

Description was changed from

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.
==========

to

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.
==========

[sra1, 2016-01-23 02:40:32]

Description was changed from

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.
==========

to

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.

Fixes issue 25566
==========

[sra1, 2016-01-23 02:41:04]

Description was changed from

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.

Fixes issue 25566
==========

to

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.

Fixes issue https://github.com/dart-lang/sdk/issues/25566
==========

[sra1, 2016-01-23 02:44:35]

Patchset #2 (id:30001) has been deleted

[sra1, 2016-01-26 04:33:29]

Patchset #3 (id:70001) has been deleted

[sra1, 2016-01-26 04:33:35]

Patchset #2 (id:50001) has been deleted

[sra1, 2016-01-26 04:40:51]

Description was changed from

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.

Fixes issue https://github.com/dart-lang/sdk/issues/25566
==========

to

==========
List constructor sentinel must not implement 'int' (extend JSInt).

Having a regular object that 'is' a number was causing horrible problems for
type inference and generated code quality.

To get this to work required fixes in type inference and the collection of
reified default argument values.

Fixes issue https://github.com/dart-lang/sdk/issues/25566

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a01c6a1cfacb1013e8acca2bc7422dfb5c8c408
==========

[sra1, 2016-01-26 04:40:52]

Committed patchset #2 (id:90001) manually as
4a01c6a1cfacb1013e8acca2bc7422dfb5c8c408 (presubmit successful).