Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1629533003: Issue 25404. 'Inline Method' should update implicit 'this' and class references. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 6 chunks +35 lines, -26 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 3 chunks +77 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-23 00:48:09 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-23 01:19:41 UTC) #2
scheglov
4 years, 11 months ago (2016-01-23 01:22:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
523756107554abc9398bf2c6c1a2b7011e103728 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698