Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1629503002: Revert of de-proc sk_float_rsqrt (Closed)

Created:
4 years, 11 months ago by mtklein
Modified:
4 years, 11 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of de-proc sk_float_rsqrt (patchset #3 id:40001 of https://codereview.chromium.org/1616013003/ ) Reason for revert: This is somehow blocking the Google3 roll in ways neither Ben nor I understand. Precautionary revert... will try again Monday. Original issue's description: > de-proc sk_float_rsqrt > > This is the first of many little baby steps to have us stop runtime-detecting NEON. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616013003 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d TBR=reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ed814f34c72248c7eecf3b0a5f335c3a7c2e9dd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -22 lines) Patch
M include/private/SkFloatingPoint.h View 2 chunks +8 lines, -15 lines 0 comments Download
M src/core/SkOpts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkOpts.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A src/opts/SkFloatingPoint_opts.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/opts/SkOpts_neon.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/MathTest.cpp View 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of de-proc sk_float_rsqrt
4 years, 11 months ago (2016-01-22 19:51:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1629503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1629503002/1
4 years, 11 months ago (2016-01-22 19:51:33 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 19:51:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ed814f34c72248c7eecf3b0a5f335c3a7c2e9dd1

Powered by Google App Engine
This is Rietveld 408576698