Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 16295016: Update sync::WeakHandle to use WeakPtr<T>::get() (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, haitaol1, tim (not reviewing), Ryan Sleevi
Visibility:
Public.

Description

Update sync::WeakHandle to use WeakPtr<T>::get() This wasn't caught by the automated pass. BUG=245942 R=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M sync/internal_api/public/util/weak_handle.h View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+rlarocque for review +rsleevi fyi
7 years, 6 months ago (2013-06-03 18:45:36 UTC) #1
rlarocque
lgtm
7 years, 6 months ago (2013-06-03 18:58:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/16295016/1
7 years, 6 months ago (2013-06-03 19:00:01 UTC) #3
akalin
7 years, 6 months ago (2013-06-03 21:09:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r203771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698