Issue 162943004: [Refactor] Always pass in screen coordinates to UIControlsAura::SendMouseMove()

Issue 162943004: [Refactor] Always pass in screen coordinates to UIControlsAura::SendMouseMove() (Closed)

Created:
6 years, 10 months ago by pkotwicz

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, ben+aura_chromium.org, sadrul, ben+ash_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Refactor] Always pass in screen coordinates to UIControlsAura::SendMouseMove() BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251900

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -57 lines)			Patch
M	ash/test/ui_controls_factory_ash.cc	View		3 chunks	+8 lines, -18 lines	0 comments	Download
M	ui/aura/test/ui_controls_factory_aurawin.cc	View		1 chunk	+5 lines, -7 lines	0 comments	Download
M	ui/aura/test/ui_controls_factory_aurax11.cc	View	1	1 chunk	+14 lines, -10 lines	0 comments	Download
M	ui/base/test/ui_controls.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/base/test/ui_controls_internal_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/test/ui_controls_internal_win.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	ui/views/test/ui_controls_factory_desktop_aurax11.cc	View		1 chunk	+10 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

Scott, can you please take a look? There is no dependancy between this CL and ...

6 years, 10 months ago (2014-02-17 15:45:37 UTC) #1

sky

LGTM https://codereview.chromium.org/162943004/diff/190001/ui/aura/test/ui_controls_factory_aurax11.cc File ui/aura/test/ui_controls_factory_aurax11.cc (right): https://codereview.chromium.org/162943004/diff/190001/ui/aura/test/ui_controls_factory_aurax11.cc#newcode146 ui/aura/test/ui_controls_factory_aurax11.cc:146: aura::client::GetScreenPositionClient(root_window_->window()); nit: only 4.

6 years, 10 months ago (2014-02-18 17:35:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/162943004/270001

6 years, 10 months ago (2014-02-18 20:16:16 UTC) #4

Message was sent while issue was closed.

Change committed as 251900

Expand Messages | Collapse Messages