Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 162943003: Fixed clusterfuzz found crash (Closed)

Created:
6 years, 10 months ago by sugoi1
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fixed clusterfuzz found crash BUG=343461 Committed: http://code.google.com/p/skia/source/detail?r=13439

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added early return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/core/SkBitmap.cpp View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sugoi1
6 years, 10 months ago (2014-02-13 16:38:03 UTC) #1
Stephen White
LGTM. Do we need a merge to M33 here?
6 years, 10 months ago (2014-02-13 16:39:45 UTC) #2
sugoi1
On 2014/02/13 16:39:45, Stephen White wrote: > LGTM. Do we need a merge to M33 ...
6 years, 10 months ago (2014-02-13 16:41:49 UTC) #3
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-13 16:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/162943003/1
6 years, 10 months ago (2014-02-13 16:42:08 UTC) #5
reed2
https://codereview.chromium.org/162943003/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/162943003/diff/1/src/core/SkBitmap.cpp#newcode1575 src/core/SkBitmap.cpp:1575: sk_bzero(&info, sizeof(SkImageInfo)); Why not just if (invalid) { return; ...
6 years, 10 months ago (2014-02-13 16:55:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 17:11:23 UTC) #7
commit-bot: I haz the power
List of reviewers changed. reed@chromium.org did a drive-by without LGTM'ing!
6 years, 10 months ago (2014-02-13 17:11:24 UTC) #8
sugoi1
https://codereview.chromium.org/162943003/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/162943003/diff/1/src/core/SkBitmap.cpp#newcode1575 src/core/SkBitmap.cpp:1575: sk_bzero(&info, sizeof(SkImageInfo)); On 2014/02/13 16:55:48, reed2 wrote: > Why ...
6 years, 10 months ago (2014-02-13 18:05:52 UTC) #9
reed1
lgtm
6 years, 10 months ago (2014-02-13 18:07:24 UTC) #10
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-13 18:08:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/162943003/120001
6 years, 10 months ago (2014-02-13 18:08:58 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 18:46:15 UTC) #13
Message was sent while issue was closed. 
Change committed as 13439

Powered by Google App Engine
This is Rietveld 408576698