Issue 162943002: Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 162943002: Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (Closed)

Created:
6 years, 10 months ago by tim (not reviewing)

Modified:
6 years, 10 months ago

Reviewers:
Bernhard Bauer, Roger Tawa OOO till Jul 10th, pavely

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, pam+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (https://codereview.chromium.org/137753012/) Reason for revert: Possible build bustage on Win64. Original issue's description: > [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService > > BUG=80194 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250814 TBR=bauerb@chromium.org,rogerta@chromium.org,pavely@chromium.org NOTREECHECKS=true NOTRY=true BUG=80194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250967

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -120 lines)			Patch
D	chrome/browser/managed_mode/managed_user_signin_manager_wrapper.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	chrome/browser/managed_mode/managed_user_signin_manager_wrapper.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	10 chunks	+36 lines, -18 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_factory.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_mock.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_startup_unittest.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

tim (not reviewing)

Created Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService

6 years, 10 months ago (2014-02-13 07:07:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/162943002/1

6 years, 10 months ago (2014-02-13 07:07:28 UTC) #2

Message was sent while issue was closed.

Change committed as 250967