third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp - Issue 1629403003: Merge DOMSettableTokensList into DOMTokensList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp

Issue 1629403003: Merge DOMSettableTokensList into DOMTokensList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moar fixed tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLLinkElement.idl ('K') | « third_party/WebKit/Source/core/html/HTMLLinkElement.idl ('k') | third_party/WebKit/Source/core/html/HTMLOutputElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp b/third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp

index d600eb9d3583ba526b2e8b891bdd5c3ae2e35c86..1f6072fa43a3c23b1e3fb3b16de1d8c2c0e22846 100644

--- a/third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp

@@ -5,7 +5,7 @@

#include "core/html/HTMLLinkElement.h"

#include "core/HTMLNames.h"

-#include "core/dom/DOMSettableTokenList.h"

+#include "core/dom/DOMTokenList.h"

#include "core/dom/Document.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -78,7 +78,7 @@ TEST(HTMLLinkElementSizesAttributeTest, setSizesPropertyValue_updatesAttribute)

{

RefPtrWillBeRawPtr<Document> document = Document::create();

RefPtrWillBeRawPtr<HTMLLinkElement> link = HTMLLinkElement::create(*document, /* createdByParser: */ false);

- RefPtrWillBeRawPtr<DOMSettableTokenList> sizes = link->sizes();

+ RefPtrWillBeRawPtr<DOMTokenList> sizes = link->sizes();

EXPECT_EQ(nullAtom, sizes->value());

sizes->setValue(" a b c ");

EXPECT_EQ(" a b c ", link->getAttribute(HTMLNames::sizesAttr));

@@ -89,7 +89,7 @@ TEST(HTMLLinkElementSizesAttributeTest, setSizesAttribute_updatesSizesPropertyVa

{

RefPtrWillBeRawPtr<Document> document = Document::create();

RefPtrWillBeRawPtr<HTMLLinkElement> link = HTMLLinkElement::create(*document, /* createdByParser: */ false);

- RefPtrWillBeRawPtr<DOMSettableTokenList> sizes = link->sizes();

+ RefPtrWillBeRawPtr<DOMTokenList> sizes = link->sizes();

EXPECT_EQ(nullAtom, sizes->value());

link->setAttribute(HTMLNames::sizesAttr, "y x ");

EXPECT_EQ("y x ", sizes->value());