third_party/WebKit/Source/core/dom/Element.idl - Issue 1629403003: Merge DOMSettableTokensList into DOMTokensList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.idl

Issue 1629403003: Merge DOMSettableTokensList into DOMTokensList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moar fixed tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.idl

diff --git a/third_party/WebKit/Source/core/dom/Element.idl b/third_party/WebKit/Source/core/dom/Element.idl

index 8d7299469d04c674b6636caf0536f2101ab088d8..a516e09035e682ac49bb19b03416d2f4aae515df 100644

--- a/third_party/WebKit/Source/core/dom/Element.idl

+++ b/third_party/WebKit/Source/core/dom/Element.idl

@@ -33,7 +33,7 @@ interface Element : Node {

[Reflect] attribute DOMString id;

[Reflect=class] attribute DOMString className;

- [SameObject, PerWorldBindings] readonly attribute DOMTokenList classList;

+ [SameObject, PerWorldBindings, PutForwards=value] readonly attribute DOMTokenList classList;

tkent 2016/02/16 03:45:11 Can you do this change in a separated CL?

Yoav Weiss 2016/02/16 09:12:00 sure, removed

[MeasureAs=HasAttributes] boolean hasAttributes();

[SameObject, PerWorldBindings, ImplementedAs=attributesForBindings] readonly attribute NamedNodeMap attributes;