Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: man/html/git-hyper-blame.html

Issue 1629253002: git hyper-blame: Added approx. line number translation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@git-hyper-blame
Patch Set: Added Caveats section to man page. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_hyper_blame.py ('k') | man/man1/git-hyper-blame.1 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: man/html/git-hyper-blame.html
diff --git a/man/html/git-hyper-blame.html b/man/html/git-hyper-blame.html
index a08de12f5b9c443388f3fbe76b969d1e396e58d0..62f7cc82a1a270369a06363c3cd9509ddccc8471 100644
--- a/man/html/git-hyper-blame.html
+++ b/man/html/git-hyper-blame.html
@@ -820,19 +820,24 @@ commit) since the given person wrote it.</p></div>
</div>
</div>
<div class="sect1">
+<h2 id="_caveats">CAVEATS</h2>
+<div class="sectionbody">
+<div class="paragraph"><p>When a line skips over an ignored commit, a guess is made as to which commit
+previously modified that line, but it is not always clear where the line came
+from. If the ignored commit makes lots of changes in close proximity, in
+particular adding/removing/reordering lines, then the wrong authors may be
+blamed for nearby edits.</p></div>
+<div class="paragraph"><p>For this reason, <code>hyper-blame</code> works best when the ignored commits are be
+limited to minor changes such as formatting and renaming, not refactoring or
+other more invasive changes.</p></div>
+</div>
+</div>
+<div class="sect1">
<h2 id="_bugs">BUGS</h2>
<div class="sectionbody">
<div class="ulist"><ul>
<li>
<p>
-When a commit is ignored, hyper-blame currently just blames the same line in
- the previous version of the file. This can be wildly inaccurate if the ignored
- commit adds or removes lines, resulting in a completely wrong commit being
- blamed.
-</p>
-</li>
-<li>
-<p>
There is currently no way to pass the ignore list as a file.
</p>
</li>
@@ -864,7 +869,7 @@ from <a href="https://chromium.googlesource.com/chromium/tools/depot_tools.git">
<div id="footnotes"><hr /></div>
<div id="footer">
<div id="footer-text">
-Last updated 2016-01-28 16:40:21 AEDT
+Last updated 2016-02-05 13:43:52 AEDT
</div>
</div>
</body>
« no previous file with comments | « git_hyper_blame.py ('k') | man/man1/git-hyper-blame.1 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698