Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: man/src/git-hyper-blame.txt

Issue 1629253002: git hyper-blame: Added approx. line number translation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@git-hyper-blame
Patch Set: Mostly rewrite approx_lineno, fixing and simplifying. Lots more tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: man/src/git-hyper-blame.txt
diff --git a/man/src/git-hyper-blame.txt b/man/src/git-hyper-blame.txt
index 8943c3935b7e9d288d0d0c70abe0cd265705ff36..8a1a4bd82763eb28fca6ae59be3c8122bd42fc0d 100644
--- a/man/src/git-hyper-blame.txt
+++ b/man/src/git-hyper-blame.txt
@@ -54,10 +54,6 @@ commit) since the given person wrote it.
BUGS
----
-- When a commit is ignored, hyper-blame currently just blames the same line in
- the previous version of the file. This can be wildly inaccurate if the ignored
- commit adds or removes lines, resulting in a completely wrong commit being
- blamed.
iannucci 2016/02/05 00:55:55 maybe mention the new caveat about trying to heuri
Matt Giuca 2016/02/05 02:46:33 Done.
- There is currently no way to pass the ignore list as a file.
- It should be possible for a git repository to configure an automatic list of
commits to ignore (like `.gitignore`), so that project owners can maintain a
« git_common.py ('K') | « man/man1/git-hyper-blame.1 ('k') | tests/git_common_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698