Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 162923002: Stop skipping tests that now work. (Closed)

Created:
6 years, 10 months ago by Adam Rice
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Stop skipping tests that now work. A few more WebSocket layout tests now pass with the new implementation. Remove them from the TestExpectations. BUG=339373 TEST=run_webkit_tests --debug http/tests/websocket Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168532

Patch Set 1 #

Patch Set 2 : Add no-crash-on-cookie-flood.html to SlowTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M LayoutTests/SlowTests View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Adam Rice
6 years, 10 months ago (2014-02-20 10:49:55 UTC) #1
yhirano
lgtm
6 years, 10 months ago (2014-02-20 10:55:59 UTC) #2
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 10 months ago (2014-02-20 11:25:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/162923002/1
6 years, 10 months ago (2014-02-20 11:25:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 15:26:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13353
6 years, 10 months ago (2014-02-20 15:26:49 UTC) #6
yhirano
Unexpected flake: http/tests/websocket/no-crash-on-cookie-flood.html http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13353
6 years, 10 months ago (2014-02-20 15:34:06 UTC) #7
Adam Rice
On 2014/02/20 15:34:06, yhirano wrote: > Unexpected flake: > http/tests/websocket/no-crash-on-cookie-flood.html > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13353 This test is ...
6 years, 10 months ago (2014-02-21 03:02:02 UTC) #8
Adam Rice
On 2014/02/21 03:02:02, Adam Rice wrote: > On 2014/02/20 15:34:06, yhirano wrote: > > Unexpected ...
6 years, 9 months ago (2014-02-28 05:12:44 UTC) #9
Adam Rice
6 years, 9 months ago (2014-03-05 05:59:35 UTC) #10
tyoshino (SeeGerritForStatus)
lgtm
6 years, 9 months ago (2014-03-05 06:00:38 UTC) #11
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 9 months ago (2014-03-05 06:02:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/162923002/230001
6 years, 9 months ago (2014-03-05 06:03:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/162923002/230001
6 years, 9 months ago (2014-03-05 20:56:43 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 21:03:53 UTC) #15
Message was sent while issue was closed.
Change committed as 168532

Powered by Google App Engine
This is Rietveld 408576698