content/browser/frame_host/interstitial_page_impl.h - Issue 1629013002: Allow a main interstitial frame to act as an ExtensionMessagePort opener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 1629013002: Allow a main interstitial frame to act as an ExtensionMessagePort opener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extension-message-port-onDisconnect-580882

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/extension_message_port.cc ('K') | « chrome/test/data/extensions/api_test/messaging/interstitial_component/manifest.json ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | content/browser/frame_host/render_frame_host_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/interstitial_page_impl.h

diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h

index 0bb90cfda1d2acb498a6c703423395c8cf3db4c9..324429e0d9b91e6e0045162d96212e2d1e1bf77b 100644

--- a/content/browser/frame_host/interstitial_page_impl.h

+++ b/content/browser/frame_host/interstitial_page_impl.h

@@ -107,6 +107,7 @@ class CONTENT_EXPORT InterstitialPageImpl

int32_t page_id,

const base::string16& title,

base::i18n::TextDirection title_direction) override;

+ InterstitialPage* GetAsInterstitialPage() override;

AccessibilityMode GetAccessibilityMode() const override;

void Cut() override;

void Copy() override;

@@ -157,7 +158,7 @@ class CONTENT_EXPORT InterstitialPageImpl

#endif

bool enabled() const { return enabled_; }

- WebContents* web_contents() const;

+ WebContents* web_contents() const override;

const GURL& url() const { return url_; }

// Creates the WebContentsView that shows the interstitial RVH.