Issue 16290002: Android: Throttle BeginFrame messages sent from the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16290002: Android: Throttle BeginFrame messages sent from the browser. (Closed)

Created:
7 years, 6 months ago by no sievers

Modified:
7 years, 6 months ago

Reviewers:
brianderson

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Throttle BeginFrame messages sent from the browser. BUG=

Patch Set 1 #

Patch Set 2 : only allow one pending beginFrame #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_android.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1	3 chunks	+14 lines, -2 lines	1 comment	Download
M	content/renderer/gpu/mailbox_output_surface.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sami

7 years, 6 months ago (2013-06-04 11:24:55 UTC) #2

https://codereview.chromium.org/16290002/diff/2001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/16290002/diff/2001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_view_android.cc:429: bool
enabled) {
We should probably get rid of |enabled| on this message so that there aren't two
parties fighting over the vsync notification state.

Expand Messages | Collapse Messages