Issue 162883002: Primary FontData of FontFallbackList should have space character

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 162883002: Primary FontData of FontFallbackList should have space character (Closed)

Created:
6 years, 10 months ago by Kunihiko Sakamoto

Modified:
6 years, 10 months ago

Reviewers:
dglazkov, eae

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Primary FontData of FontFallbackList should have space character This patch makes FontFallbackList::primaryFontData() skips SegmentedFontData that does not have space character. FontFallbackList::primarySimpleFontData() expects primaryFontData has FontData for space character. This prevents @font-face with unicode-range outside space character (for example, overrides only an ampersand) from being downloaded unnecessarily, and used as primary font. BUG=247920 TEST=fast/css/font-face-unicode-range-load.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167130

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -4 lines)			Patch
M	LayoutTests/fast/css/font-face-character-fallback.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/css/font-face-unicode-range-load.html	View	3 chunks	+14 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/css/font-face-unicode-range-load-expected.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/FontFallbackList.cpp	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	Source/platform/fonts/SegmentedFontData.h	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

The CQ bit was checked by ksakamoto@chromium.org

6 years, 10 months ago (2014-02-14 00:46:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/162883002/1

6 years, 10 months ago (2014-02-14 00:46:23 UTC) #4

Message was sent while issue was closed.

Change committed as 167130

Expand Messages | Collapse Messages