Issue 1628643002: Merge to XFA: Fixed object references in CPDF_Object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1628643002: Merge to XFA: Fixed object references in CPDF_Object (Closed)

Created:
4 years, 11 months ago by Wei Li

Modified:
4 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fixed object references in CPDF_Object This is a regression from commit 90853cb. BUG=pdfium:365 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1617043004 . (cherry picked from commit 7671d304ca4d3aec658c0ac8d5eea4c64e23b144) Committed: https://pdfium.googlesource.com/pdfium/+/33ea6308c45f1ea8ee7dd1f77852a255ef176301

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -3 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Wei Li

4 years, 11 months ago (2016-01-23 02:45:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
33ea6308c45f1ea8ee7dd1f77852a255ef176301 (presubmit successful).